Skip to content

Commit

Permalink
Remove dependency between objc_peeerconnectionfactory_base and libvpx.
Browse files Browse the repository at this point in the history
The data-channel only target "peerconnectionfactory_no_media_objc"
transitively depends on libvpx via "peerconnectionfactory_base_objc".

This CL breaks the dependency between "objc_peeerconnectionfactory_base"
and libvpx moving RTCVideoCodecVP8.mm and RTCVideoCodecVP9.mm to
"peerconnectionfactory_objc" (together with RTCVideoCodecH264.mm).

Bug: webrtc:8594
Change-Id: Idfe3024163012925f017ad8c585b7ae21e86c319
Reviewed-on: https://webrtc-review.googlesource.com/27480
Reviewed-by: Magnus Jedvert <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#20969}
  • Loading branch information
MirkoBonadei authored and Commit Bot committed Dec 1, 2017
1 parent 4ba5a7d commit 8e28c56
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions sdk/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,8 @@ if (is_ios || is_mac) {
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory+Private.h",
"objc/Framework/Classes/PeerConnection/RTCPeerConnectionFactory.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP8.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP9.mm",
]

public_configs = [ ":common_config_objc" ]
Expand All @@ -348,6 +350,8 @@ if (is_ios || is_mac) {
"../api/video_codecs:video_codecs_api",
"../media:rtc_audio_video",
"../media:rtc_media_base",
"../modules/video_coding:webrtc_vp8",
"../modules/video_coding:webrtc_vp9",
"../pc:create_pc_factory",
"../pc:peerconnection",
"../rtc_base:rtc_base",
Expand Down Expand Up @@ -443,8 +447,6 @@ if (is_ios || is_mac) {
"objc/Framework/Classes/PeerConnection/RTCVideoCapturer.m",
"objc/Framework/Classes/PeerConnection/RTCVideoCodec+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoCodec.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP8.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoCodecVP9.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoEncoderSettings.mm",
"objc/Framework/Classes/PeerConnection/RTCVideoFrame+Private.h",
"objc/Framework/Classes/PeerConnection/RTCVideoFrame.mm",
Expand Down Expand Up @@ -513,8 +515,6 @@ if (is_ios || is_mac) {
"../common_video",
"../media:rtc_media_base",
"../modules:module_api",
"../modules/video_coding:webrtc_vp8",
"../modules/video_coding:webrtc_vp9",
"../pc:peerconnection",
"../rtc_base:rtc_base",
]
Expand Down

0 comments on commit 8e28c56

Please sign in to comment.