Skip to content

Commit

Permalink
Revert "Revert "Make some more targets publicly visible""
Browse files Browse the repository at this point in the history
This reverts commit 55d1809.

Reason for revert: This cl was not the culprit for breaking chrome content/renderer deps.

Original change's description:
> Revert "Make some more targets publicly visible"
> 
> This reverts commit 60d1792.
> 
> Reason for revert: 
> 
> Breaks Chrome FYI:
> 
> /b/c/b/Linux_Builder/src/buildtools/linux64/gn gen //out/Release --check
>   -> returned 1
> ERROR at //build/split_static_library.gni:12:5: Dependency not allowed.
>     static_library(target_name) {
>     ^----------------------------
> The item //content/renderer:renderer
> can not depend on //third_party/webrtc/media:rtc_internal_video_codecs
> because it is not in //third_party/webrtc/media:rtc_internal_video_codecs's visibility list: [
>   //third_party/webrtc/*
>   //third_party/webrtc_overrides/*
> ]
> 
>  https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webrtc.fyi%2FLinux_Builder%2F23560%2F%2B%2Frecipes%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout
> 
> Original change's description:
> > Make some more targets publicly visible
> > 
> > To fix build errors introduced by
> > https://webrtc-review.googlesource.com/c/src/+/24140
> > 
> > BUG=webrtc:8254
> > NOTRY=true
> > 
> > Change-Id: I9cdf9cee39735368af78291134dbad70aebb7195
> > Reviewed-on: https://webrtc-review.googlesource.com/38660
> > Commit-Queue: Karl Wiberg <[email protected]>
> > Reviewed-by: Mirko Bonadei <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#21552}
> 
> [email protected],[email protected]
> 
> Change-Id: I475ac382218fa77d33abc595f0773275d715a28e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: webrtc:8254
> Reviewed-on: https://webrtc-review.googlesource.com/38740
> Reviewed-by: Per Kjellander <[email protected]>
> Commit-Queue: Per Kjellander <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#21554}

[email protected],[email protected],[email protected]

Change-Id: If8e9b7b1c934ec4b5ed61941c845e62e43bef97e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:8254
Reviewed-on: https://webrtc-review.googlesource.com/38841
Reviewed-by: Per Kjellander <[email protected]>
Commit-Queue: Per Kjellander <[email protected]>
Cr-Commit-Position: refs/heads/master@{#21559}
  • Loading branch information
perkj authored and Commit Bot committed Jan 10, 2018
1 parent a7f2d84 commit a0f5f60
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions media/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ rtc_static_library("rtc_constants") {
}

rtc_static_library("rtc_internal_video_codecs") {
visibility = [ "*" ]
defines = []
libs = []
deps = [
Expand Down
1 change: 1 addition & 0 deletions modules/video_capture/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import("../../webrtc.gni")
# 'video_capture_internal_impl' depending on whether they want to
# use the internal capturer.
rtc_static_library("video_capture_module") {
visibility = [ "*" ]
sources = [
"device_info_impl.cc",
"device_info_impl.h",
Expand Down
1 change: 1 addition & 0 deletions rtc_tools/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ if (!build_with_chromium) {
}

rtc_static_library("event_log_visualizer_utils") {
visibility = [ "*" ]
sources = [
"event_log_visualizer/analyzer.cc",
"event_log_visualizer/analyzer.h",
Expand Down

0 comments on commit a0f5f60

Please sign in to comment.