Skip to content

Commit

Permalink
Disable WavWriterTest flaky tests on Mac.
Browse files Browse the repository at this point in the history
[email protected]

Bug: webrtc:9247
Change-Id: I3d01ac5dd7d6ac2ff83f2b991238ce003c0182e9
Reviewed-on: https://webrtc-review.googlesource.com/74880
Reviewed-by: Alessio Bazzica <[email protected]>
Commit-Queue: Alessio Bazzica <[email protected]>
Cr-Commit-Position: refs/heads/master@{#23152}
  • Loading branch information
alebzk authored and Commit Bot committed May 7, 2018
1 parent 27e2b7d commit d5ef6ff
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions common_audio/wav_file_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,22 @@
#include "test/gtest.h"
#include "test/testsupport/fileutils.h"

// WavWriterTest.CPPFileDescriptor and WavWriterTest.CPP flaky on Mac.
// See webrtc:9247.
#if defined(WEBRTC_MAC)
#define MAYBE_CPP DISABLED_CPP
#define MAYBE_CPPFileDescriptor DISABLED_CPPFileDescriptor
#else
#define MAYBE_CPP CPP
#define MAYBE_CPPFileDescriptor CPPFileDescriptor
#endif

namespace webrtc {

static const float kSamples[] = {0.0, 10.0, 4e4, -1e9};

// Write a tiny WAV file with the C++ interface and verify the result.
TEST(WavWriterTest, CPP) {
TEST(WavWriterTest, MAYBE_CPP) {
const std::string outfile = test::OutputPath() + "wavtest1.wav";
static const size_t kNumSamples = 3;
{
Expand Down Expand Up @@ -176,7 +186,7 @@ TEST(WavWriterTest, LargeFile) {

// Write a tiny WAV file with the the std::FILE interface and verify the
// result.
TEST(WavWriterTest, CPPFileDescriptor) {
TEST(WavWriterTest, MAYBE_CPPFileDescriptor) {
const std::string outfile = test::OutputPath() + "wavtest1.wav";
static constexpr size_t kNumSamples = 3;
{
Expand Down

0 comments on commit d5ef6ff

Please sign in to comment.