MDL-52805 core: Remove legacy log calls

admin/tool/admin_presets/classes/event/preset_deleted.php

@@ -36,10 +36,6 @@ public function get_description(): string {
         return "User {$this->userid} has deleted the preset with id {$this->objectid}.";
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'delete', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'd';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/classes/event/preset_exported.php

@@ -41,10 +41,6 @@ public function get_url(): \moodle_url {
             ['action' => 'load', 'mode' => 'preview', 'id' => $this->objectid]);
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'export', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'c';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/classes/event/preset_imported.php

@@ -41,10 +41,6 @@ public function get_url(): \moodle_url {
             ['action' => 'load', 'mode' => 'preview', 'id' => $this->objectid]);
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'import', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'c';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/classes/event/preset_loaded.php

@@ -41,10 +41,6 @@ public function get_url(): \moodle_url {
             ['action' => 'load', 'mode' => 'preview', 'id' => $this->objectid]);
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'load', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'u';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/classes/event/preset_reverted.php

@@ -36,10 +36,6 @@ public function get_description(): string {
         return "User {$this->userid} has reverted the preset with id {$this->objectid}.";
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'rollback', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'u';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/classes/event/presets_listed.php

@@ -40,10 +40,6 @@ public function get_url(): \moodle_url {
         return new \moodle_url('/admin/tool/admin_presets/index.php');
     }
 
-    public function get_legacy_logdata(): array {
-        return [$this->courseid, 'tool_admin_presets', 'base', '', $this->objectid, $this->contextinstanceid];
-    }
-
     protected function init(): void {
         $this->data['crud'] = 'r';
         $this->data['edulevel'] = self::LEVEL_OTHER;

admin/tool/admin_presets/tests/event/preset_deleted_test.php

@@ -55,7 +55,5 @@ public function test_preset_deleted_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\preset_deleted', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'delete', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/admin_presets/tests/event/preset_exported_test.php

@@ -55,7 +55,5 @@ public function test_preset_exported_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\preset_exported', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'export', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/admin_presets/tests/event/preset_imported_test.php

@@ -55,7 +55,5 @@ public function test_preset_imported_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\preset_imported', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'import', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/admin_presets/tests/event/preset_loaded_test.php

@@ -55,7 +55,5 @@ public function test_preset_loaded_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\preset_loaded', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'load', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/admin_presets/tests/event/preset_reverted_test.php

@@ -55,7 +55,5 @@ public function test_preset_reverted_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\preset_reverted', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'rollback', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/admin_presets/tests/event/presets_listed_test.php

@@ -55,7 +55,5 @@ public function test_presets_listed_event() {
         $this->assertInstanceOf('\tool_admin_presets\event\presets_listed', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
         $this->assertEquals($presetid, $event->objectid);
-        $expected = [0, 'tool_admin_presets', 'base', '', $presetid, 0];
-        $this->assertEventLegacyLogData($expected, $event);
     }
 }

admin/tool/capability/classes/event/report_viewed.php

@@ -62,15 +62,6 @@ public function get_description() {
         return "The user with id '$this->userid' viewed the capability overview report.";
     }
 
-    /**
-     * Return the legacy event log data.
-     *
-     * @return array
-     */
-    protected function get_legacy_logdata() {
-        return array(SITEID, 'admin', 'tool capability', 'tool/capability/index.php');
-    }
-
     /**
      * Returns relevant URL.
      *

admin/tool/capability/tests/event/events_test.php

@@ -55,8 +55,6 @@ public function test_report_viewed() {
 
         $this->assertInstanceOf('\tool_capability\event\report_viewed', $event);
         $this->assertEquals(\context_system::instance(), $event->get_context());
-        $expected = array(SITEID, "admin", "tool capability", "tool/capability/index.php");
-        $this->assertEventLegacyLogData($expected, $event);
         $this->assertEventContextNotUsed($event);
         $url = new \moodle_url('/admin/tool/capability/index.php');
         $this->assertEquals($url, $event->get_url());

admin/tool/log/store/legacy/tests/fixtures/event.php

@@ -44,21 +44,4 @@ protected function init() {
     public function get_url() {
         return new \moodle_url('/somepath/somefile.php', array('id' => $this->data['other']['sample']));
     }
-
-    public static function get_legacy_eventname() {
-        return 'test_legacy';
-    }
-
-    protected function get_legacy_eventdata() {
-        return array($this->data['courseid'], $this->data['other']['sample']);
-    }
-
-    protected function get_legacy_logdata() {
-        $cmid = 0;
-        if ($this->contextlevel == CONTEXT_MODULE) {
-            $cmid = $this->contextinstanceid;
-        }
-        return array($this->data['courseid'], 'core_unittest', 'view',
-            'unittest.php?id=' . $this->data['other']['sample'], 'bbb', $cmid);
-    }
 }

auth/ldap/tests/plugin_test.php

@@ -379,9 +379,6 @@ public function test_ldap_user_loggedin_event() {
         $this->assertEquals('user', $event->objecttable);
         $this->assertEquals('2', $event->objectid);
         $this->assertEquals(\context_system::instance()->id, $event->contextid);
-        $expectedlog = array(SITEID, 'user', 'login', 'view.php?id=' . $USER->id . '&course=' . SITEID, $user->id,
-            0, $user->id);
-        $this->assertEventLegacyLogData($expectedlog, $event);
     }
 
     /**
@@ -508,10 +505,7 @@ public function test_ldap_user_signup() {
         $event = array_pop($events);
         $this->assertInstanceOf('\core\event\user_created', $event);
         $this->assertEquals($user['id'], $event->objectid);
-        $this->assertEquals('user_created', $event->get_legacy_eventname());
         $this->assertEquals(\context_user::instance($user['id']), $event->get_context());
-        $expectedlogdata = array(SITEID, 'user', 'add', '/view.php?id='.$event->objectid, fullname($dbuser));
-        $this->assertEventLegacyLogData($expectedlogdata, $event);
 
         // First event is user_password_updated.
         $event = array_pop($events);

blog/tests/event/events_test.php

@@ -137,10 +137,6 @@ public function test_blog_entry_created_event() {
         $this->assertEquals($USER->id, $event->userid);
         $this->assertEquals($this->userid, $event->relateduserid);
         $this->assertEquals("post", $event->objecttable);
-        $arr = array(SITEID, 'blog', 'add', 'index.php?userid=' . $this->userid . '&entryid=' . $blog->id, $blog->subject);
-        $this->assertEventLegacyLogData($arr, $event);
-        $this->assertEquals("blog_entry_added", $event->get_legacy_eventname());
-        $this->assertEventLegacyData($blog, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -172,10 +168,6 @@ public function test_blog_entry_updated_event() {
         $this->assertEquals($USER->id, $event->userid);
         $this->assertEquals($this->userid, $event->relateduserid);
         $this->assertEquals("post", $event->objecttable);
-        $this->assertEquals("blog_entry_edited", $event->get_legacy_eventname());
-        $this->assertEventLegacyData($blog, $event);
-        $arr = array (SITEID, 'blog', 'update', 'index.php?userid=' . $this->userid . '&entryid=' . $blog->id, $blog->subject);
-        $this->assertEventLegacyLogData($arr, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -207,11 +199,6 @@ public function test_blog_entry_deleted_event() {
         $this->assertEquals($this->userid, $event->relateduserid);
         $this->assertEquals("post", $event->objecttable);
         $this->assertEquals($record, $event->get_record_snapshot("post", $blog->id));
-        $this->assertSame('blog_entry_deleted', $event->get_legacy_eventname());
-        $arr = array(SITEID, 'blog', 'delete', 'index.php?userid=' . $blog->userid, 'deleted blog entry with entry id# ' .
-                $blog->id);
-        $this->assertEventLegacyLogData($arr, $event);
-        $this->assertEventLegacyData($blog, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -292,9 +279,6 @@ public function test_blog_association_created_event() {
         $this->assertEquals($USER->id, $event->userid);
         $this->assertEquals($this->userid, $event->relateduserid);
         $this->assertEquals('blog_association', $event->objecttable);
-        $arr = array(SITEID, 'blog', 'add association', 'index.php?userid=' . $this->userid . '&entryid=' . $blog->id,
-                     $blog->subject, 0, $this->userid);
-        $this->assertEventLegacyLogData($arr, $event);
 
         // Add blog associations with a module.
         $blog = new \blog_entry($this->postid);
@@ -308,9 +292,6 @@ public function test_blog_association_created_event() {
         $this->assertEquals($blog->id, $event->other['blogid']);
         $this->assertEquals($this->cmid, $event->other['associateid']);
         $this->assertEquals('coursemodule', $event->other['associatetype']);
-        $arr = array(SITEID, 'blog', 'add association', 'index.php?userid=' . $this->userid . '&entryid=' . $blog->id,
-                     $blog->subject, $this->cmid, $this->userid);
-        $this->assertEventLegacyLogData($arr, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -393,10 +374,7 @@ public function test_blog_entries_viewed_event() {
 
         // Validate event data.
         $url = new \moodle_url('/blog/index.php', $other);
-        $url2 = new \moodle_url('index.php', $other);
         $this->assertEquals($url, $event->get_url());
-        $arr = array(SITEID, 'blog', 'view', $url2->out(), 'view blog entry');
-        $this->assertEventLegacyLogData($arr, $event);
         $this->assertEventContextNotUsed($event);
     }
 

calendar/tests/event/events_test.php

@@ -87,10 +87,8 @@ public function test_calendar_event_created() {
         $this->assertEquals('event', $event->objecttable);
         $this->assertEquals(0, $event->courseid);
         $this->assertEquals($calevent->context, $event->get_context());
-        $expectedlog = array(0, 'calendar', 'add', 'event.php?action=edit&id=' . $calevent->id , $calevent->name);
         $other = array('repeatid' => 0, 'timestart' => $time, 'name' => 'event');
         $this->assertEquals($other, $event->other);
-        $this->assertEventLegacyLogData($expectedlog, $event);
         $this->assertEventContextNotUsed($event);
 
         // Now we create a repeated course event.
@@ -194,8 +192,6 @@ public function test_calendar_event_updated() {
         $this->assertEquals('event', $event->objecttable);
         $this->assertEquals(0, $event->courseid);
         $this->assertEquals($calevent->context, $event->get_context());
-        $expectedlog = array(0, 'calendar', 'edit', 'event.php?action=edit&id=' . $calevent->id , $calevent->name);
-        $this->assertEventLegacyLogData($expectedlog, $event);
         $other = array('repeatid' => 0, 'timestart' => $time, 'name' => 'new event');
         $this->assertEquals($other, $event->other);
         $this->assertEventContextNotUsed($event);
@@ -249,8 +245,6 @@ public function test_calendar_event_updated_toggle_visibility() {
         $this->assertEquals('event', $event->objecttable);
         $this->assertEquals($siteid, $event->courseid);
         $this->assertEquals($calevent->context, $event->get_context());
-        $expectedlog = [$siteid, 'calendar', 'edit', 'event.php?action=edit&id=' . $calevent->id , $calevent->name];
-        $this->assertEventLegacyLogData($expectedlog, $event);
         $other = array('repeatid' => 0, 'timestart' => $time, 'name' => 'Some wickedly awesome event yo!');
         $this->assertEquals($other, $event->other);
         $this->assertEventContextNotUsed($event);

cohort/tests/lib_test.php

@@ -102,7 +102,6 @@ public function test_cohort_add_cohort_event() {
         $url = new \moodle_url('/cohort/index.php', array('contextid' => $event->contextid));
         $this->assertEquals($url, $event->get_url());
         $this->assertEquals($cohort, $event->get_record_snapshot('cohort', $id));
-        $this->assertEventLegacyData($cohort, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -179,7 +178,6 @@ public function test_cohort_update_cohort_event() {
         $url = new \moodle_url('/cohort/edit.php', array('id' => $event->objectid));
         $this->assertEquals($url, $event->get_url());
         $this->assertEquals($cohort, $event->get_record_snapshot('cohort', $id));
-        $this->assertEventLegacyData($cohort, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -219,7 +217,6 @@ public function test_cohort_delete_cohort_event() {
         $url = new \moodle_url('/cohort/index.php', array('contextid' => $event->contextid));
         $this->assertEquals($url, $event->get_url());
         $this->assertEquals($cohort, $event->get_record_snapshot('cohort', $cohort->id));
-        $this->assertEventLegacyData($cohort, $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -279,7 +276,6 @@ public function test_cohort_add_member_event() {
         $this->assertEquals($USER->id, $event->userid);
         $url = new \moodle_url('/cohort/assign.php', array('id' => $event->objectid));
         $this->assertEquals($url, $event->get_url());
-        $this->assertEventLegacyData((object) array('cohortid' => $cohort->id, 'userid' => $user->id), $event);
         $this->assertEventContextNotUsed($event);
     }
 
@@ -325,7 +321,6 @@ public function test_cohort_remove_member_event() {
         $this->assertEquals($USER->id, $event->userid);
         $url = new \moodle_url('/cohort/assign.php', array('id' => $event->objectid));
         $this->assertEquals($url, $event->get_url());
-        $this->assertEventLegacyData((object) array('cohortid' => $cohort->id, 'userid' => $user->id), $event);
         $this->assertEventContextNotUsed($event);
     }
 

course/classes/category.php

@@ -2179,8 +2179,6 @@ public function delete_move($newparentid, $showfeedback = false) {
                     'objectid' => $childcat->id,
                     'context' => $childcat->get_context()
                 ));
-                $event->set_legacy_logdata(array(SITEID, 'category', 'move', 'editcategory.php?id=' . $childcat->id,
-                    $childcat->id));
                 $event->trigger();
             }
             fix_course_sortorder();
@@ -2371,7 +2369,6 @@ public function change_parent($newparentcat) {
                 'objectid' => $this->id,
                 'context' => $this->get_context()
             ));
-            $event->set_legacy_logdata(array(SITEID, 'category', 'move', 'editcategory.php?id=' . $this->id, $this->id));
             $event->trigger();
         }
     }
@@ -2443,7 +2440,6 @@ public function hide() {
                 'objectid' => $this->id,
                 'context' => $this->get_context()
             ));
-            $event->set_legacy_logdata(array(SITEID, 'category', 'hide', 'editcategory.php?id=' . $this->id, $this->id));
             $event->trigger();
         }
     }
@@ -2502,7 +2498,6 @@ public function show() {
                 'objectid' => $this->id,
                 'context' => $this->get_context()
             ));
-            $event->set_legacy_logdata(array(SITEID, 'category', 'show', 'editcategory.php?id=' . $this->id, $this->id));
             $event->trigger();
         }
     }
@@ -3066,8 +3061,6 @@ public function change_sortorder_by_one($up) {
                 'objectid' => $this->id,
                 'context' => $this->get_context()
             ));
-            $event->set_legacy_logdata(array(SITEID, 'category', 'move', 'management.php?categoryid=' . $this->id,
-                $this->id));
             $event->trigger();
 
             // Finally reorder courses.

course/lib.php

@@ -2024,7 +2024,6 @@ function move_courses($courseids, $categoryid) {
                              'fullname' => $dbcourse->fullname,
                              'updatedfields' => array('category' => $category->id))
         ));
-        $event->set_legacy_logdata(array($course->id, 'course', 'move', 'edit.php?id=' . $course->id, $course->id));
         $event->trigger();
     }
     fix_course_sortorder();
@@ -2490,7 +2489,6 @@ function update_course($data, $editoroptions = NULL) {
                          'updatedfields' => $updatedfields)
     ));
 
-    $event->set_legacy_logdata(array($course->id, 'course', 'update', 'edit.php?id=' . $course->id, $course->id));
     $event->trigger();
 
     if ($oldcourse->format !== $course->format) {

course/resources.php

@@ -51,7 +51,6 @@
 
 // Triger view event.
 $event = \core\event\course_resources_list_viewed::create(array('context' => context_course::instance($course->id)));
-$event->set_legacy_logdata($availableresources);
 $event->add_record_snapshot('course', $course);
 $event->trigger();