Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing & Refactoring #205

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Typing & Refactoring #205

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d8d6313
refactor code to improve clarity, begin adding typing
dsfulf Jul 25, 2024
6402ea9
add typing, some refactoring
dsfulf Jul 25, 2024
d3890e9
debugging
dsfulf Jul 25, 2024
da9993a
further debugging
dsfulf Jul 25, 2024
0efa73f
debug text alignment
dsfulf Jul 25, 2024
8f85ece
fix wet_grass test
dsfulf Jul 25, 2024
ce79215
final renaming for style
dsfulf Jul 25, 2024
1a7d2bd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2024
32998c1
fix use of Union | in expressions
dsfulf Jul 25, 2024
adda265
Merge branch 'typing' of https://github.com/daft-dev/daft into typing
dsfulf Jul 25, 2024
521f8b1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2024
4af6e4f
fix use of Union | in all typing
dsfulf Jul 25, 2024
6d3f072
Merge branch 'typing' of https://github.com/daft-dev/daft into typing
dsfulf Jul 25, 2024
6ad5487
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2024
40d0f83
missed the Union types...
dsfulf Jul 25, 2024
b69ae2b
Merge branch 'typing' of https://github.com/daft-dev/daft into typing
dsfulf Jul 25, 2024
7ab8bd9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 25, 2024
3e4b228
add wet_grass.png to tracking
dsfulf Jul 25, 2024
92f3e11
Merge branch 'typing' of https://github.com/daft-dev/daft into typing
dsfulf Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add wet_grass.png to tracking 
Signed-off-by: David Fulford <[email protected]>
  • Loading branch information
@dsfulf
dsfulf committed Jul 25, 2024
commit 3e4b2286e702073bb7d0091667af6c52166522db
Binary file added test/baseline_images/test_examples/wet_grass.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.