*: support substr. (pingcap#2422)

daliniu · Jan 9, 2017 · b2ce51a · b2ce51a
1 parent 677a85b
commit b2ce51a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/ast/functions.go b/ast/functions.go
@@ -145,6 +145,7 @@ const (
 	Space          = "space"
 	Strcmp         = "strcmp"
 	Substring      = "substring"
+	Substr         = "substr"
 	SubstringIndex = "substring_index"
 	Trim           = "trim"
 	Upper          = "upper"

diff --git a/expression/builtin.go b/expression/builtin.go
@@ -215,6 +215,7 @@ var Funcs = map[string]Func{
 	ast.Space:          {builtinSpace, 1, 1},
 	ast.Strcmp:         {builtinStrcmp, 2, 2},
 	ast.Substring:      {builtinSubstring, 2, 3},
+	ast.Substr:         {builtinSubstring, 2, 3},
 	ast.SubstringIndex: {builtinSubstringIndex, 3, 3},
 	ast.Trim:           {builtinTrim, 1, 3},
 	ast.Upper:          {builtinUpper, 1, 1},

diff --git a/plan/logical_plan_test.go b/plan/logical_plan_test.go
@@ -577,6 +577,10 @@ func (s *testPlanSuite) TestPlanBuilder(c *C) {
 			sql:  "do sleep(5)",
 			plan: "*plan.TableDual->Projection",
 		},
+		{
+			sql:  "select substr(\"abc\", 1)",
+			plan: "*plan.TableDual->Projection",
+		},
 	}
 	for _, ca := range cases {
 		comment := Commentf("for %s", ca.sql)