[License] Enable unnecessary_parenthesis lint

dama2716588 · Dec 20, 2018 · 2b207a5 · 2b207a5
1 parent 97ae271
commit 2b207a5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/tools/licenses/analysis_options.yaml b/tools/licenses/analysis_options.yaml
@@ -68,6 +68,7 @@ linter:
     - unnecessary_getters_setters
     - unnecessary_new
     - unnecessary_overrides
+    - unnecessary_parenthesis
     - unnecessary_statements
     - unnecessary_this
     - package_names
diff --git a/tools/licenses/lib/filesystem.dart b/tools/licenses/lib/filesystem.dart
@@ -59,7 +59,7 @@ const String kMultiLicenseFileHeader = 'Notices for files contained in';
 
 bool isMultiLicenseNotice(Reader reader) {
   final List<int> bytes = reader();
-  return (ascii.decode(bytes.take(kMultiLicenseFileHeader.length).toList(), allowInvalid: true) == kMultiLicenseFileHeader);
+  return ascii.decode(bytes.take(kMultiLicenseFileHeader.length).toList(), allowInvalid: true) == kMultiLicenseFileHeader;
 }
 
 FileType identifyFile(String name, Reader reader) {

diff --git a/tools/licenses/lib/licenses.dart b/tools/licenses/lib/licenses.dart
@@ -656,9 +656,9 @@ Iterable<_PartialLicenseMatch> _findLicenseBlocks(String body, RegExp pattern, i
         if (lastWasBlank && (foundNonBlank || !needsCopyright))
           break;
         lastWasBlank = true;
-      } else if (((!isBlockCommentLine && line.startsWith('/*')) ||
-                 line.startsWith('<!--') ||
-                 (range.start == 0 && line.startsWith('  $fullPrefix')))) {
+      } else if ((!isBlockCommentLine && line.startsWith('/*'))
+                 || line.startsWith('<!--')
+                 || (range.start == 0 && line.startsWith('  $fullPrefix'))) {
         start = range.start;
         firstLineSpecialComment = true;
         break;