Skip to content

Commit

Permalink
Include _http into sky_engine libraries for analyzer (flutter#4154)
Browse files Browse the repository at this point in the history
  • Loading branch information
aam authored Sep 29, 2017
1 parent 86f95f0 commit b930f10
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
8 changes: 8 additions & 0 deletions sky/packages/sky_engine/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import("//dart/sdk/lib/collection/collection_sources.gni")
import("//dart/sdk/lib/convert/convert_sources.gni")
import("//dart/sdk/lib/core/core_sources.gni")
import("//dart/sdk/lib/developer/developer_sources.gni")
import("//dart/sdk/lib/_http/http_sources.gni")
import("//dart/sdk/lib/internal/internal_sources.gni")
import("//dart/sdk/lib/io/io_sources.gni")
import("//dart/sdk/lib/isolate/isolate_sources.gni")
Expand Down Expand Up @@ -64,6 +65,12 @@ copy("developer") {
outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/developer/{{source_file_part}}" ]
}

copy("_http") {
lib_path = rebase_path("_http", "", dart_sdk_lib_path)
sources = rebase_path(http_sdk_sources, "", lib_path)
outputs = [ "$root_gen_dir/dart-pkg/sky_engine/lib/_http/{{source_file_part}}" ]
}

copy("internal") {
lib_path = rebase_path("internal", "", dart_sdk_lib_path)
sources = rebase_path(internal_sdk_sources, "", lib_path)
Expand Down Expand Up @@ -109,6 +116,7 @@ group("copy_dart_sdk") {
":convert",
":core",
":developer",
":_http",
":internal",
":io",
":isolate",
Expand Down
1 change: 1 addition & 0 deletions sky/packages/sky_engine/lib/_embedder.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ embedded_libs:
# API, e.g. List being Iterable by virtue of implementing
# EfficientLengthIterable.
# Not including this library yields analysis errors.
"dart:_http": "_http/http.dart"
"dart:_internal": "internal/internal.dart"
"dart:nativewrappers": "_empty.dart"

Expand Down

0 comments on commit b930f10

Please sign in to comment.