Skip to content

Commit

Permalink
Rename review-period-end to last-call-deadline (#4438)
Browse files Browse the repository at this point in the history
* Rename review-period-end to last-call-deadline

* Update eipv to 0.4.0
  • Loading branch information
axic authored Nov 10, 2021
1 parent ed6a52e commit 214064e
Show file tree
Hide file tree
Showing 17 changed files with 17 additions and 20 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ matrix:
- language: rust
cache: cargo
before_script:
- cargo install eipv --version=0.3.0
- cargo install eipv --version=0.4.0
env: TASK='eip-validator'
- python: 3.3
env: TASK='codespell'
Expand Down
4 changes: 2 additions & 2 deletions EIPS/eip-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ The following is the standardization process for all EIPs in all tracks:

**Review** - An EIP Author marks an EIP as ready for and requesting Peer Review.

**Last Call** - This is the final review window for an EIP before moving to `FINAL`. An EIP editor will assign `Last Call` status and set a review end date (review-period-end), typically 14 days later.
**Last Call** - This is the final review window for an EIP before moving to `FINAL`. An EIP editor will assign `Last Call` status and set a review end date (`last-call-deadline`), typically 14 days later.

If this period results in necessary normative changes it will revert the EIP to `REVIEW`.

Expand Down Expand Up @@ -127,7 +127,7 @@ Each EIP must begin with an [RFC 822](https://www.ietf.org/rfc/rfc822.txt) style

` status:` *Draft, Review, Last Call, Final, Stagnant, Withdrawn, Living*

` * review-period-end:` *date review period ends*
` * last-call-deadline:` *The date last call period ends on*

` type:` *Standards Track, Meta, or Informational*

Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-1191.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ eip: 1191
title: Add chain id to mixed-case checksum address encoding
author: Juliano Rizzo (@juli)
status: Last Call
review-period-end: 2019-11-18
last-call-deadline: 2019-11-18
type: Standards Track
category: ERC
created: 2018-03-18
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-1271.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Standard Signature Validation Method for Contracts
author: Francisco Giordano (@frangio), Matt Condon (@shrugs), Philippe Castonguay (@PhABC), Amir Bandeali (@abandeali1), Jorge Izquierdo (@izqui), Bertrand Masius (@catageek)
discussions-to: https://github.com/ethereum/EIPs/issues/1271
status: Last Call
review-period-end: 2021-07-26
last-call-deadline: 2021-07-26
type: Standards Track
category: ERC
created: 2018-07-25
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-173.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ discussions-to: https://github.com/ethereum/EIPs/issues/173
type: Standards Track
category: ERC
status: Last Call
review-period-end: 2020-09-06
last-call-deadline: 2020-09-06
created: 2018-06-07
---

Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-2266.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ status: Last Call
type: Standards Track
category: ERC
created: 2019-08-17
review-period-end: 2020-12-31
last-call-deadline: 2020-12-31
---

## Simple Summary
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-2481.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: "eth/66: request identifier"
author: Christoph Burgdorf (@cburgdorf)
discussions-to: https://github.com/ethereum/EIPs/issues/2482
status: Last Call
review-period-end: 2021-08-11
last-call-deadline: 2021-08-11
type: Standards Track
category: Networking
created: 2020-01-17
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-2535.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Diamonds, Multi-Facet Proxy
author: Nick Mudge (@mudgen)
discussions-to: https://github.com/ethereum/EIPs/issues/2535
status: Last Call
review-period-end: 2020-08-15
last-call-deadline: 2020-08-15
type: Standards Track
category: ERC
created: 2020-02-22
Expand Down
1 change: 0 additions & 1 deletion EIPS/eip-2678.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ title: Revised Ethereum Smart Contract Packaging Standard (EthPM v3)
author: g. nicholas d’andrea (@gnidan), Piper Merriam (@pipermerriam), Nick Gheorghita (@njgheorghita), Christian Reitwiessner (@chriseth), Ben Hauser (@iamdefinitelyahuman), Bryant Eisenbach (@fubuloubu)
discussions-to: https://ethereum-magicians.org/t/ethpm-v3-specification-working-group/4086
status: Final
review-period-end: 2021-04-14
type: Standards Track
category: ERC
created: 2020-05-26
Expand Down
1 change: 0 additions & 1 deletion EIPS/eip-2786.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ title: Ethereum Provider Connect/Disconnect Events
author: Micah Zoltu (@MicahZoltu), Erik Marks (@rekmarks)
discussions-to: https://github.com/ethereum/EIPs/issues/2787
status: Withdrawn
review-period-end: 2020-07-31
type: Standards Track
category: Interface
created: 2020-07-15
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-2976.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ status: Last Call
type: Standards Track
category: Networking
created: 2020-09-13
review-period-end: 2021-10-06
last-call-deadline: 2021-10-06
requires: 2718
---

Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-2982.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Serenity Phase 0
author: Danny Ryan (@djrtwo), Vitalik Buterin (@vbuterin)
discussions-to: https://ethereum-magicians.org/t/serenity-phase-0-eip/4621
status: Last Call
review-period-end: 2021-09-09
last-call-deadline: 2021-09-09
type: Informational
created: 2020-09-15
---
Expand Down
2 changes: 1 addition & 1 deletion EIPS/eip-3076.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ status: Last Call
type: Standards Track
category: Interface
created: 2020-10-27
review-period-end: 2021-11-03
last-call-deadline: 2021-11-03
---

## Abstract
Expand Down
1 change: 0 additions & 1 deletion EIPS/eip-875.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ title: Simpler NFT standard with batching and native atomic swaps
author: Weiwu Zhang <[email protected]>, James Sangalli <[email protected]>
discussions-to: https://github.com/ethereum/EIPs/issues/875
status: Withdrawn
review-period-end: 2019-07-29
type: Standards Track
category: ERC
created: 2018-02-08
Expand Down
4 changes: 2 additions & 2 deletions _includes/eiptable.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ <h2 id="{{status|slugify}}">{{status}}</h2>
{% for page in eips %}
<tr>
<td class="eipnum"><a href="{{page.url|relative_url}}">{{page.eip|xml_escape}}</a></td>
{% if status == "Last Call" and page.review-period-end != undefined %}
<td class="date">{{ page.review-period-end | xml_escape }}</td>
{% if status == "Last Call" and page.last-call-deadline != undefined %}
<td class="date">{{ page.last-call-deadline | xml_escape }}</td>
{% endif %}
<td class="title">{{page.title|xml_escape}}</td>
<td class="author">{% include authorlist.html authors=page.author %}</td>
Expand Down
4 changes: 2 additions & 2 deletions _layouts/eip.html
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ <h3>{{ page.description | xml_escape }}</h3>
<tr><th>Discussions-To</th><td><a href="{{ page["discussions-to"] | uri_escape }}">{{ page["discussions-to"] | xml_escape }}</a></td></tr>
{% endif %}
<tr><th>Status</th><td>{{ page.status | xml_escape }}
{% if page.review-period-end != undefined %}
<tr><th>Review period ends</th><td>{{ page.review-period-end | xml_escape }}</td></tr>
{% if page.last-call-deadline != undefined %}
<tr><th>Last Call Deadline</th><td>{{ page.last-call-deadline | xml_escape }}</td></tr>
{% endif %}
</td></tr>
<tr><th>Type</th><td>{{ page.type | xml_escape }}</td></tr>
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ <h2>EIP status terms</h2>
<li><strong>Idea</strong> - An idea that is pre-draft. This is not tracked within the EIP Repository.
<li><strong>Draft</strong> - The first formally tracked stage of an EIP in development. An EIP is merged by an EIP Editor into the EIP repository when properly formatted.</li>
<li><strong>Review</strong> - An EIP Author marks an EIP as ready for and requesting Peer Review.</li>
<li><strong>Last Call</strong> - This is the final review window for an EIP before moving to FINAL. An EIP editor will assign Last Call status and set a review end date (review-period-end), typically 14 days later. If this period results in necessary normative changes it will revert the EIP to Review.</li>
<li><strong>Last Call</strong> - This is the final review window for an EIP before moving to FINAL. An EIP editor will assign Last Call status and set a review end date (`last-call-deadline`), typically 14 days later. If this period results in necessary normative changes it will revert the EIP to Review.</li>
<li><strong>Final</strong> - This EIP represents the final standard. A Final EIP exists in a state of finality and should only be updated to correct errata and add non-normative clarifications.</li>
<li><strong>Stagnant</strong> - Any EIP in Draft or Review if inactive for a period of 6 months or greater is moved to Stagnant. An EIP may be resurrected from this state by Authors or EIP Editors through moving it back to Draft.</li>
<li><strong>Withdrawn</strong> - The EIP Author(s) have withdrawn the proposed EIP. This state has finality and can no longer be resurrected using this EIP number. If the idea is pursued at later date it is considered a new proposal.</li>
Expand Down

0 comments on commit 214064e

Please sign in to comment.