Include last call review-end-date in the rendered summary (#2918)

* Include last call review-end-date in the rendered summary * Split review-period-ends line into its own on the EIP render
danfinlay · Sep 3, 2020 · 6fce40f · 6fce40f
1 parent d90e668
commit 6fce40f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/_includes/eiptable.html b/_includes/eiptable.html
@@ -14,11 +14,19 @@
     <h2 id="{{status|slugify}}">{{status}}</h2>
     <table class="eiptable">
       <thead>
-        <tr><th class="eipnum">Number</th><th class="title">Title</th><th class="author">Author</th></tr>
+        {% if status == "Last Call" %}
+          <tr>
+          <th class="eipnum">Number</th><th class="date">Review ends</th><th class="title">Title</th><th class="author">Author</th></tr>
+        {% else %}
+          <tr><th class="eipnum">Number</th><th class="title">Title</th><th class="author">Author</th></tr>
+        {% endif %}
       </thead>
       {% for page in eips %}
         <tr>
           <td class="eipnum"><a href="{{page.url|relative_url}}">{{page.eip|xml_escape}}</a></td>
+          {% if status == "Last Call" and page.review-period-end != undefined %}
+            <td class="date">{{ page.review-period-end | xml_escape }}</td>
+          {% endif %}
           <td class="title">{{page.title|xml_escape}}</td>
           <td class="author">{% include authorlist.html authors=page.author %}</td>
         </tr>

diff --git a/_layouts/eip.html b/_layouts/eip.html
@@ -14,7 +14,7 @@ <h1 class="page-heading">
     {% endif %}
     <tr><th>Status</th><td>{{ page.status | xml_escape }}
     {% if page.review-period-end != undefined %}
-      <strong>(review ends {{ page.review-period-end | xml_escape }})</strong>
+      <tr><th>Review period ends</th><td>{{ page.review-period-end | xml_escape }}</td></tr>
     {% endif %}
     </td></tr>
     <tr><th>Type</th><td>{{ page.type | xml_escape }}</td></tr>