Skip to content

Commit

Permalink
Add TODO to make Put.recordSizelimit() abstract in the next major
Browse files Browse the repository at this point in the history
The record size limit is now an implementation detail of the node, so
should be set in the node implementation.
  • Loading branch information
Gavin Norman authored and matthias-wende-sociomantic committed May 9, 2019
1 parent 319a56d commit 84eb155
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/dhtproto/node/request/Put.d
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,12 @@ public abstract scope class Put : SingleKey

/***************************************************************************
TODO: this method should be made abstract, as the record size limit is
now intended to be an implementation detail of the node, rather than
a constant defined by the protcol. Not making this abstract now in order
to avoid a breaking change in a minor branch, but using the magic word
"deprecated" so we'll find it when we do the next major release.
Returns:
the maximum size (in bytes) allowed for a record to be added to the
storage engine
Expand Down

0 comments on commit 84eb155

Please sign in to comment.