Merge pull request jupyterhub#576 from yuvipanda/no-multi-hub

Revert "Set maxUnavailable appropriately for hub & proxy pods"
danielmaitre · Mar 15, 2018 · 68725f5 · 68725f5
2 parents f21eab6 + 26ed088
commit 68725f5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 19 deletions.
diff --git a/jupyterhub/templates/hub/deployment.yaml b/jupyterhub/templates/hub/deployment.yaml
@@ -4,19 +4,6 @@ metadata:
   name: hub
 spec:
   replicas: 1
-  strategy:
-    rollingUpdate:
-      {{ if eq .Values.hub.db.type "sqlite-pvc" }}
-      # If we're using a PVC, set maxUnavailable to 1
-      # This is required, since the pod attached to PVC must die
-      # before new pod can run.
-      maxUnavailable: 1
-      {{ else }}
-      # If we aren't using a PVC, it's ok to spawn up a new pod
-      # before killing the currently running one. This also makes the '--wait'
-      # flag of helm work properly
-      maxUnavailable: 0
-      {{ end }}
   template:
     metadata:
       labels:

diff --git a/jupyterhub/templates/proxy/deployment.yaml b/jupyterhub/templates/proxy/deployment.yaml
@@ -9,12 +9,6 @@ metadata:
   name: proxy
 spec:
   replicas: 1
-  strategy:
-      rollingUpdate:
-          # There's no PVCs attached here, so is ok to set maxUnavailable to 1
-          # This means new pod will be spun up and traffic transferred to it
-          # before old pod is shut down.
-          maxUnavailable: 1
   template:
     metadata:
       annotations: