Exclude moment from the library #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
We do use moment, I am fine that I need to include this adapter my self as an extra package but I do hope we keep it simple and just don't fully remove it.. No I don't like the option to copy some code. That suddenly means all kind of forks.. |
|
Sure, no problem. I'll try to think of a better solution. To keep it but not to bundle it with all those locales, hopefully 😄 I will close this PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Recently I found out that moment is including a lot of stuff I do not need because I'm not using moment for the i18n. And as I saw anyone can add an adapter I decided to help out a little it and make a PR to completely remove moment from the package.
Here are some screenshots before and after. I literally saved 100kb+ 😱
With moment included by default.
Without moment.
