Skip to content

Commit

Permalink
Revert "[cmake] Turn on the -Wbool-conversion flag." (r32925)
Browse files Browse the repository at this point in the history
I complained about not having this to Michael, but it turns out it's on by
default and just doesn't catch the issue we ran into.

Swift SVN r32931
  • Loading branch information
jrose-apple committed Oct 28, 2015
1 parent 0ceb040 commit 6bc2234
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cmake/modules/SwiftSharedCMakeConfig.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,6 @@ macro(swift_common_cxx_warnings)
# Check for '-fapplication-extension'. On OSX/iOS we wish to link all
# dynamic libraries with this flag.
check_cxx_compiler_flag("-fapplication-extension" CXX_SUPPORTS_FAPPLICATION_EXTENSION)

check_cxx_compiler_flag("-Werror -Wbool-conversion" CXX_SUPPORTS_BOOL_CONVERSION_WARNING_FLAG)
append_if(CXX_SUPPORTS_BOOL_CONVERSION_WARNING_FLAG "-Wbool-conversion" CMAKE_CXX_FLAGS)
endmacro()

# Like 'llvm_config()', but uses libraries from the selected build
Expand Down

0 comments on commit 6bc2234

Please sign in to comment.