QCache: fix accidental pessimization

By unconditionally removing the existing entry we never
hit the if (result.initialized) branch. Change it to
only remove the existing entry if we don't plan on inserting.

Task-number: QTBUG-88183
Pick-to: 6.0 6.0.0
Change-Id: If4e7ebac23aa63d4b9d4b0a22882dd7d90a58e8b
Reviewed-by: Lars Knoll <[email protected]>

src/corelib/tools/qcache.h

@@ -236,10 +236,9 @@ class QCache
 
     bool insert(const Key &key, T *object, qsizetype cost = 1)
     {
-        remove(key);
-
         if (cost > mx) {
             delete object;
+            remove(key);
             return false;
         }
         trim(mx - cost);