ReplicatedPG::_scrub: don't bail early for snapdir

Fixes: ceph#7937 Signed-off-by: Samuel Just <[email protected]>
dano · Apr 2, 2014 · 01445d5 · 01445d5
1 parent dde1c91
commit 01445d5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/src/common/hobject.h b/src/common/hobject.h
@@ -102,6 +102,11 @@ struct hobject_t {
     return ret;
   }
 
+  /// @return true if object is snapdir
+  bool is_snapdir() const {
+    return snap == CEPH_SNAPDIR;
+  }
+
   /// @return true if object is head
   bool is_head() const {
     return snap == CEPH_NOSNAP;

diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc
@@ -11109,11 +11109,6 @@ void ReplicatedPG::_scrub(ScrubMap& scrubmap)
 	}	  
       }
     }
-    if (soid.snap == CEPH_SNAPDIR) {
-      string cat;
-      scrub_cstat.add(stat, cat);
-      continue;
-    }
 
     // basic checks.
     if (p->second.attrs.count(OI_ATTR) == 0) {
@@ -11140,10 +11135,12 @@ void ReplicatedPG::_scrub(ScrubMap& scrubmap)
 
     stat.num_bytes += oi.size;
 
-    if (oi.is_dirty())
-      ++stat.num_objects_dirty;
-    if (oi.is_whiteout())
-      ++stat.num_whiteouts;
+    if (!soid.is_snapdir()) {
+      if (oi.is_dirty())
+	++stat.num_objects_dirty;
+      if (oi.is_whiteout())
+	++stat.num_whiteouts;
+    }
 
     //bufferlist data;
     //osd->store->read(c, poid, 0, 0, data);