JI-2084 Fix synced status update after resync

danowar2k · Dec 3, 2020 · c0d152b · c0d152b
1 parent 0cf6c8f
commit c0d152b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/locallib.php b/locallib.php
@@ -666,7 +666,7 @@ function hvp_update_hub_status($content) {
 
   // Only check sync status when waiting
   if (empty($content['contentHubId']) || $synced !== H5PContentHubSyncStatus::WAITING) {
-      return;
+      return false;
   }
 
   $core = \mod_hvp\framework::instance();
@@ -675,6 +675,8 @@ function hvp_update_hub_status($content) {
       $core->h5pF->updateContentFields($content['id'], array('synced' => $newstate));
       return $newstate;
   }
+
+  return false;
 }
 
 /**

diff --git a/view.php b/view.php
@@ -81,7 +81,7 @@
 // Update Hub status for content before printing out messages
 if ($hashub && $isshared) {
     $newstate = hvp_update_hub_status($content);
-    $synced = $newstate ? $newstate : intval($content['synced']);
+    $synced = $newstate !== false ? $newstate : intval($content['synced']);
     $huboptionsdata['canbesynced'] = $synced !== \H5PContentHubSyncStatus::SYNCED && $synced !== \H5PContentHubSyncStatus::WAITING;
     $huboptionsdata['waitingclass'] = $synced === \H5PContentHubSyncStatus::WAITING ? '' : ' hidden';
     $huboptionsdata['token'] = \H5PCore::createToken('share_' . $id);