Proposed Changes to add a Start Trigger and Reset Trigger #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzitzow
requested changes
Jan 14, 2019
| @@ -171,14 +172,14 @@ export default class AudioRecorder extends React.Component<AudioRecorderProps, A | |||
| [ | |||
| 'AudioRecorder-button', | |||
| this.state.audioData ? 'hasAudio' : '', | |||
| this.state.isPlaying ? 'isPlaying' : '', | |||
| // this.state.isPlaying ? 'isPlaying' : '', | |||
There was a problem hiding this comment.
Please remove commented out code
|
Gavin, I don't maintain this project but I'm using it and looking at extending it too. I'm thinking about reaching out to @danrouse and seeing if he wants any help maintaining the project. Do you have any interest in this pull request getting added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added two more props,
startRecording?: boolean, reset?: boolean,And attached them to a didUpdate to be able to have more functionality over your package.
componentDidUpdate() { { this.props.startRecording ? this.startRecording() : undefined } { this.props.reset ? this.onRemoveClick() : undefined } }I also updated Readme to reflect these changes.