create singleton only when module is enabled #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged. Thanks for this! |
|
thanks! could you tag a new release please? We may not checkout the master branch on Production Systems ;) |
|
Good point, 1.1.1 tagged! |
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magento has a bug, where an exception is thrown, when you try to load a non existant singleton for the 2nd time.
The first time, the registry key is created with the value false.
The 2nd time, it will try to create the key again (because the condition is only if (!self::registry($registryKey)), but should be checking if the key is set) and raise an Exception.