fix(RuleFailure): don't force uppercase on ruleSeverity in toJson imp…

…lementation (palantir#2622)
dantxal · Oct 5, 2019 · 524f8b2 · 524f8b2
1 parent 68c3a14
commit 524f8b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/language/rule/rule.ts b/src/language/rule/rule.ts
@@ -342,7 +342,7 @@ export class RuleFailure {
                     : this.fix.toJson(),
             name: this.fileName,
             ruleName: this.ruleName,
-            ruleSeverity: this.ruleSeverity.toUpperCase(),
+            ruleSeverity: this.ruleSeverity,
             startPosition: this.startPosition.toJson(),
         };
     }

diff --git a/test/formatters/jsonFormatterTests.ts b/test/formatters/jsonFormatterTests.ts
@@ -73,7 +73,7 @@ describe("JSON Formatter", () => {
                     character: 1,
                 },
                 ruleName: "first-name",
-                ruleSeverity: "ERROR",
+                ruleSeverity: "error",
             },
             {
                 name: TEST_FILE,
@@ -89,7 +89,7 @@ describe("JSON Formatter", () => {
                     character: 0,
                 },
                 ruleName: "last-name",
-                ruleSeverity: "ERROR",
+                ruleSeverity: "error",
             },
             {
                 name: TEST_FILE,
@@ -110,9 +110,10 @@ describe("JSON Formatter", () => {
                     character: 0,
                 },
                 ruleName: "full-name",
-                ruleSeverity: "ERROR",
+                ruleSeverity: "error",
             },
         ];
+
         /* tslint:enable:object-literal-sort-keys */
 
         const actualResult = JSON.parse(formatter.format(failures));