-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting to solidity v. 0.5.0 #18
base: master
Are you sure you want to change the base?
Conversation
Nice work !! Your PR helped me lot with V 0.5.0 .Thanks n keep the good work. |
Thank you! :) @pathakcodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should have been merged in long ago?
For what it's worth I ended up coming to pretty much the same changes in my own upgrades. Though it seems to me that the build directory should be ignored in addition to the node_modules.
@@ -0,0 +1,2 @@ | |||
.gitignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the .gitignore file ignoring itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it seems the build directory should be ignored?
In case someone is running into the same issue I am having of using Solidity You need to wrap |
No description provided.