Skip to content

Commit

Permalink
winbind: Fix passing idmap failure from wb_sids2xids back to callers
Browse files Browse the repository at this point in the history
If the idmap call in wb_sids2xids fails, the callers expect xid.type to
be set to ID_TYPE_NOT_SPECIFIED, not the internal type field that is
initialized from the lookupsids call.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12295

Signed-off-by: Christof Schmitt <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>

Autobuild-User(master): Jeremy Allison <[email protected]>
Autobuild-Date(master): Fri Sep 30 02:10:29 CEST 2016 on sn-devel-144
  • Loading branch information
chs authored and jrasamba committed Sep 30, 2016
1 parent 7a3b780 commit 1f9501c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source3/winbindd/wb_sids2xids.c
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ static void wb_sids2xids_done(struct tevent_req *subreq)
* All we can do here is to report "not mapped"
*/
for (i=0; i<src->num_ids; i++) {
src->ids[i].type = ID_TYPE_NOT_SPECIFIED;
src->ids[i].xid.type = ID_TYPE_NOT_SPECIFIED;
}
}

Expand Down

0 comments on commit 1f9501c

Please sign in to comment.