Skip to content

Commit

Permalink
rpmd: Add a TODO regarding the additional work performed
Browse files Browse the repository at this point in the history
Signed-off-by: Garming Sam <[email protected]>
Reviewed-by: Andrew Bartlett <[email protected]>
  • Loading branch information
GSam committed Sep 8, 2016
1 parent d6a16b4 commit 434bf4a
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions source4/dsdb/samdb/ldb_modules/repl_meta_data.c
Original file line number Diff line number Diff line change
Expand Up @@ -2600,6 +2600,16 @@ static int replmd_modify_handle_linked_attribs(struct ldb_module *module,
return LDB_SUCCESS;
}

/*
* TODO:
*
* We should restrict this to the intersection of the list of
* linked attributes in the schema and the list of attributes
* being modified.
*
* This will help performance a little, as otherwise we have
* to allocate the entire object value-by-value.
*/
ret = dsdb_module_search_dn(module, msg, &res, msg->dn, NULL,
DSDB_FLAG_NEXT_MODULE |
DSDB_SEARCH_SHOW_RECYCLED |
Expand Down

0 comments on commit 434bf4a

Please sign in to comment.