Skip to content

Commit

Permalink
torture/smb2/ioctl: don't check for untruncated dest failure
Browse files Browse the repository at this point in the history
This should fail, but passes against WS2016 RTM...

2.3.8 FSCTL_DUPLICATE_EXTENTS_TO_FILE Reply:
The destination range extends beyond the target file's allocation size.
The caller might need to increase the target's allocation size before
using FSCTL_DUPLICATE_EXTENTS_TO_FILE.

Signed-off-by: David Disseldorp <[email protected]>
Reviewed-by: Jeremy Allison <[email protected]>
  • Loading branch information
ddiss authored and jrasamba committed Sep 22, 2016
1 parent 281ce60 commit 710f067
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions source4/torture/smb2/ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -5039,12 +5039,14 @@ static bool test_ioctl_dup_extents_len_beyond_dest(struct torture_context *tctx,
"ndr_push_fsctl_dup_extents_to_file");

status = smb2_ioctl(tree, tmp_ctx, &ioctl.smb2);
#if 0
/*
* 2.3.8 FSCTL_DUPLICATE_EXTENTS_TO_FILE Reply - this should fail, but
* passes against WS2016 RTM!
*/
torture_assert_ntstatus_equal(tctx, status, NT_STATUS_NOT_SUPPORTED,
"FSCTL_DUP_EXTENTS_TO_FILE");
#endif

/* the file sizes shouldn't have been changed */
ZERO_STRUCT(io);
Expand Down

0 comments on commit 710f067

Please sign in to comment.