s4-kdc: Do not leak memory on error in kpasswd_make_error_reply()

CID 1372874 Signed-off-by: Andreas Schneider <[email protected]> Reviewed-by: Jeremy Allison <[email protected]> Autobuild-User(master): Jeremy Allison <[email protected]> Autobuild-Date(master): Tue Sep 13 22:13:31 CEST 2016 on sn-devel-144
darabosj · Sep 13, 2016 · 8267ec2 · 8267ec2
1 parent 7a0ff3b
commit 8267ec2
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/source4/kdc/kpasswd-helper.c b/source4/kdc/kpasswd-helper.c
@@ -54,11 +54,13 @@ bool kpasswd_make_error_reply(TALLOC_CTX *mem_ctx,
 	 */
 #ifndef SAMBA4_USES_HEIMDAL
 	if (slen < 2) {
+		talloc_free(s);
 		return false;
 	}
 	slen -= 2;
 #endif
 	if (2 + slen < slen) {
+		talloc_free(s);
 		return false;
 	}
 	error_data->length = 2 + slen;