Skip to content

Commit

Permalink
Removing warning suppression flags in common_audio/.
Browse files Browse the repository at this point in the history
Bug: webrtc:9251
Change-Id: I9cae182ceb5e6bd3d6a34dc1a336ee3900f4cc98
Reviewed-on: https://webrtc-review.googlesource.com/86946
Reviewed-by: Karl Wiberg <[email protected]>
Commit-Queue: Mirko Bonadei <[email protected]>
Cr-Commit-Position: refs/heads/master@{#23839}
  • Loading branch information
MirkoBonadei authored and Commit Bot committed Jul 4, 2018
1 parent e12c1fe commit f9c2952
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions common_audio/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,6 @@ rtc_static_library("common_audio") {
deps += [ ":common_audio_neon" ]
}

if (is_win) {
cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
}

public_configs = [ ":common_audio_config" ]

if (!build_with_chromium && is_clang) {
Expand Down Expand Up @@ -207,10 +203,6 @@ rtc_source_set("common_audio_c") {
]
}

if (is_win) {
cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
}

public_configs = [ ":common_audio_config" ]
deps = [
":common_audio_c_arm_asm",
Expand Down
2 changes: 1 addition & 1 deletion common_audio/real_fourier.cc
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ int RealFourier::FftOrder(size_t length) {

size_t RealFourier::FftLength(int order) {
RTC_CHECK_GE(order, 0);
return static_cast<size_t>(1 << order);
return size_t{1} << order;
}

size_t RealFourier::ComplexLength(int order) {
Expand Down
2 changes: 1 addition & 1 deletion common_audio/signal_processing/complex_fft.c
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ int WebRtcSpl_ComplexIFFT(int16_t frfi[], int stages, int mode)
/* The 1024-value is a constant given from the size of kSinTable1024[],
* and should not be changed depending on the input parameter 'stages'
*/
n = 1 << stages;
n = ((size_t)1) << stages;
if (n > 1024)
return -1;

Expand Down

0 comments on commit f9c2952

Please sign in to comment.