Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Runtime version checks #1995

Merged
merged 4 commits into from
Feb 16, 2025
Merged

[ffigen] Runtime version checks #1995

merged 4 commits into from
Feb 16, 2025

Conversation

liamappelbe
Copy link
Contributor

@liamappelbe liamappelbe commented Feb 14, 2025

Add a runtime check that the OS version is >= the version that an API was introduced. Do this check in interface constructors, interface methods, and category methods.

Fixes #300

Copy link

github-actions bot commented Feb 14, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Non-Breaking 5.0.0 6.0.0-wip 5.1.0 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
objective_c _Version

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@coveralls
Copy link

coveralls commented Feb 14, 2025

Coverage Status

coverage: 91.662% (+3.6%) from 88.092%
when pulling 80b8f0f on vercheck
into ddfb5b1 on main.

@liamappelbe liamappelbe marked this pull request as ready for review February 14, 2025 04:22
@liamappelbe liamappelbe merged commit 23a387d into main Feb 16, 2025
22 checks passed
@liamappelbe liamappelbe deleted the vercheck branch February 16, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ffigen] ObjC version compatibility runtime check
3 participants