logger: add question mark for query strings #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Landed with 0f0a4a0 Thank you! |
natebosch
pushed a commit
that referenced
this pull request
May 3, 2022
Configures the construction of the WebSocketChannel.
natebosch
added a commit
that referenced
this pull request
May 3, 2022
This function had unnecessary complexity because it took optional arguments that were never passed. The entire behavior can also be written with a short enough pattern that it isn't worthwhile to have a separate function for it.
natebosch
pushed a commit
that referenced
this pull request
May 3, 2022
natebosch
pushed a commit
that referenced
this pull request
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.