Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move analysis_options.yaml into packages #460

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

devoncarew
Copy link
Member

  • move analysis_options.yaml into packages
  • regenerate mono_repo files

This catches a number of diagnostics in the shelf packages (mostly instances of comment_references diagnostics).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo
Copy link
Member

kevmoo commented Nov 22, 2024

But don't we like having fewer analysis_options files? Is this to work-around an analyzer bug?

@devoncarew
Copy link
Member Author

But don't we like having fewer analysis_options files?

Well, fewer analysis configurations for sure. Most of these are just include: package:dart_flutter_team_lints/analysis_options.yaml, which isn't really a maintenance issue.

Is this to work-around an analyzer bug?

I think there is a bug here, because I see different analysis results w/ one top level analysis file vs. the same configs, one in each package.

But I like having the packages be self-contained - not depend on files above them in the repo. And this also removes the persistent analysis diagnostic you see if you open the whole repo; the top-level analysis options file can't resolve its reference to package:dart_flutter_team_lints.

@devoncarew devoncarew merged commit 2b5b683 into dart-lang:master Dec 2, 2024
22 checks passed
@devoncarew devoncarew deleted the update_analysis branch December 2, 2024 18:28
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 3, 2024
lints (https://github.com/dart-lang/lints/compare/2e1321e..e1d4794):
  e1d4794  2024-12-03  Michael Goderbauer  Revert "Update README.md before archiving (`#214`)" (dart-lang/lints#219)

shelf (https://github.com/dart-lang/shelf/compare/657ebd3..2b5b683):
  2b5b683  2024-12-02  Devon Carew  move analysis_options.yaml into packages (dart-lang/shelf#460)

sse (https://github.com/dart-lang/sse/compare/befbd6d..b97dc3a):
  b97dc3a  2024-12-02  dependabot[bot]  Bump dart-lang/setup-dart in the github-actions group (dart-archive/sse#119)

test (https://github.com/dart-lang/test/compare/c2a6986..2096773):
  20967732  2024-12-03  Devon Carew  Update the use of 'package:shelf_web_socket's `webSocketHandler` method (dart-lang/test#2421)
  1d28d738  2024-12-02  Ben Konyi  Support `package:vm_service` 15.x (dart-lang/test#2420)

Change-Id: I852515f46f12b53d2a2fe665a57f7ddcfde36222
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/398605
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants