Migrate code excerpter packages to null safety #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlough
force-pushed
the
migrate/migrate-code-excerpter-tools
branch
from
8e2f6e2 to
2b4bce0
Compare
parlough
changed the title
|
@RedBrogdon Can you review this or assign someone on the devrel team? No rush as I'm waiting on the infrastructure changes to be complete first. @kevmoo Could you also take a look if you get a chance? Thanks! 💙 |
kevmoo
approved these changes
Jan 10, 2022
parlough
force-pushed
the
migrate/migrate-code-excerpter-tools
branch
from
c3ed387 to
2fe6d5f
Compare
parlough
force-pushed
the
migrate/migrate-code-excerpter-tools
branch
from
2fe6d5f to
64e23d7
Compare
|
Hey @parlough! Sorry I missed this PR. I'll give it a review by EOD tomorrow! |
khanhnwin
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Null safety changes LGTM! Thank you @parlough!
Though, this is my first time reviewing such a large chunk of Dart code! @johnpryan @domesticmouse can either of you please give this a quick once-over to make sure I didn't miss anything? Thank you!
domesticmouse
approved these changes
Feb 2, 2022
johnpryan
approved these changes
Feb 2, 2022
|
Can someone squash and merge this? I don't have commit access to site-shared. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the code excerpter packages to the null safety. Cleans up some code with new language features and standards along the way.
Fixes #143
For review: @khanhnwin