Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom hostname and TLS options #2588

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Wdestroier
Copy link

Fixes #953.

@bkonyi bkonyi self-requested a review February 10, 2025 16:41
@Wdestroier
Copy link
Author

@bkonyi Hi, I reformatted the code. Should I update the dwds/CHANGELOG.md file too?

image

@bkonyi
Copy link
Collaborator

bkonyi commented Feb 10, 2025

@bkonyi Hi, I reformatted the code. Should I update the dwds/CHANGELOG.md file too?

Nope, I can disable that check for you!

Overall this looks good to me, but ideally we'd add a test to make sure we don't regress in the future. Is that something you'd be willing to do?

@Wdestroier
Copy link
Author

Overall this looks good to me, but ideally we'd add a test to make sure we don't regress in the future. Is that something you'd be willing to do?

Hi @bkonyi, I added the tests.

@Wdestroier
Copy link
Author

Fixed recent merge conflicts in the CHANGELOG.md file.

@Wdestroier
Copy link
Author

Will this be shipped in the next release?

Copy link
Collaborator

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests! Just a few comments.

@bkonyi
Copy link
Collaborator

bkonyi commented Feb 19, 2025

Will this be shipped in the next release?

Yes, this will be shipped with the next release of webdev 😄

@Wdestroier
Copy link
Author

Yes, this will be shipped with the next release of webdev

Awesome!

I applied the requested changes, thanks for the suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hostname is not respected when tls options are specified
2 participants