Merge pull request #18 from lucassaldanha/fix-isurl

Fix isURL hostWhitelist and hostBlacklist inverted logic
dart-league · Jun 26, 2020 · dbaaeb2 · dbaaeb2
2 parents 67220df + bf02aea
commit dbaaeb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/validators.dart b/lib/validators.dart
@@ -180,11 +180,11 @@ bool isURL(String str,
     return false;
   }
 
-  if (hostWhitelist.isNotEmpty && hostWhitelist.contains(host)) {
+  if (hostWhitelist.isNotEmpty && !hostWhitelist.contains(host)) {
     return false;
   }
 
-  if (hostBlacklist.isNotEmpty && !hostBlacklist.contains(host)) {
+  if (hostBlacklist.isNotEmpty && hostBlacklist.contains(host)) {
     return false;
   }
 

diff --git a/test/validator_test.dart b/test/validator_test.dart
@@ -100,6 +100,12 @@ main() {
 
     expect(v.isURL('www.example.com', requireProtocol: true), false);
     expect(v.isURL('example', requireTld: false), true);
+
+    expect(v.isURL('www.example.com', hostWhitelist: ['www.example.com']), true);
+    expect(v.isURL('www.example.com', hostWhitelist: ['www.another.com']), false);
+
+    expect(v.isURL('www.example.com', hostBlacklist: ['www.example.com']), false);
+    expect(v.isURL('www.example.com', hostBlacklist: ['www.another.com']), true);
   });
 
   test('IsIP', () {