Skip to content

Commit

Permalink
PCI/MSI: Use msi_mask_irq() in pci_msi_shutdown()
Browse files Browse the repository at this point in the history
commit d28d4ad2a1aef27458b3383725bb179beb8d015c upstream.

No point in using the raw write function from shutdown. Preparatory change
to introduce proper serialization for the msi_desc::masked cache.

Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Marc Zyngier <[email protected]>
Reviewed-by: Marc Zyngier <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
KAGA-KOKO authored and Sasha Levin committed Aug 26, 2021
1 parent 55db703 commit 5c8a389
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/pci/msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@ void pci_msi_shutdown(struct pci_dev *dev)

/* Return the device with MSI unmasked as initial states */
mask = msi_mask(desc->msi_attrib.multi_cap);
__pci_msi_desc_mask_irq(desc, mask, 0);
msi_mask_irq(desc, mask, 0);

/* Restore dev->irq to its default pin-assertion irq */
dev->irq = desc->msi_attrib.default_irq;
Expand Down

0 comments on commit 5c8a389

Please sign in to comment.