Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrary NSData failed to be decoded properly #12

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

hamchapman
Copy link
Contributor

Problem: Arbitrary NSData would seemingly be encoded properly but would then fail to be decoded properly, leaving an NSString in its place with the DSCborBase64DataMarker prepended.

Solution: Use dump_bytestring_base64 as opposed to dump_bytestring_base64url.

…ld then

fail to be decoded properly, leaving an NSString in its place with the
`DSCborBase64DataMarker` prepended.

Solution: Use `dump_bytestring_base64` as opposed to
`dump_bytestring_base64url`.
@hamchapman
Copy link
Contributor Author

This is probably also the fix for #9

Copy link
Contributor

@podkovyrin podkovyrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@podkovyrin
Copy link
Contributor

I'll release a new pod version with this.

@Alex-Werner
Copy link

Thank you @hamchapman !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants