Problem: Strings in the CBOR to JSON conversion code were being appended incorrectly #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded to the `out` string using `appendFormat` with the `%s` format specifier. This does not guarantee that UTF8 will be used as the encoding and it will in fact use whatever encoding is the default on the device that is running the code. On macOS, for most users, this will in fact be macOS Roman, which leads to things like `£` characters (anything that's over one byte in UTF8, really) being appended to the `out` string incorrectly, because they're appended using the wrong encoding. Solution: Explicitly use UTF8 encoding in the CBOR to JSON conversion code.
hamchapman
force-pushed
the
hc/utf8-string-fixes
branch
from
a28fbff to
82b6473
Compare
podkovyrin
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings in the CBOR to JSON conversion code were being appended to the
outstring usingappendFormatwith the%sformat specifier. This does not guarantee that UTF8 will be used as the encoding and it will in fact use whatever encoding is the default on the device that is running the code. On macOS, for most users, this will in fact be macOS Roman, which leads to things like£characters (anything that's over one byte in UTF8, really) being appended to theoutstring incorrectly, because they're appended using the wrong encoding.Solution: Explicitly use UTF8 encoding in the CBOR to JSON conversion code.