Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic if Config.Workspace.CurrentUser.User is not set #1993

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

denik
Copy link
Contributor

@denik denik commented Dec 10, 2024

Changes

Extra check to avoid panic if /api/2.0/preview/scim/v2/Me returns {}

Tests

Existing tests.

@denik denik temporarily deployed to test-trigger-is December 10, 2024 16:01 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 1993
  • Commit SHA: a80013bbb002fbc66b2b9e925aceab310248c16f

Checks will be approved automatically on success.

@denik denik temporarily deployed to test-trigger-is December 10, 2024 16:02 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

Test Details: go/deco-tests/12259986675

@denik denik enabled auto-merge December 10, 2024 16:04
@denik denik changed the title Avoid panic if User is not set Avoid panic if Config.Workspace.CurrentUser.User is not set Dec 10, 2024
@denik
Copy link
Contributor Author

denik commented Dec 11, 2024

Integration test failure is unrelated (TestAccBundleDeployUcSchema).

@denik denik disabled auto-merge December 11, 2024 08:40
@denik denik merged commit 67f08ba into main Dec 11, 2024
10 of 11 checks passed
@denik denik deleted the minor_fix branch December 11, 2024 08:40
andrewnester added a commit that referenced this pull request Dec 18, 2024
Bundles:
 * Allow overriding compute for non-development mode targets ([#1899](#1899)).
 * Avoid panic if Config.Workspace.CurrentUser.User is not set ([#1993](#1993)).
 * Show an error when using a cluster override with 'mode: production' ([#1994](#1994)).

Internal:

API Changes:
 * Added `databricks account federation-policy` command group.
 * Added `databricks account service-principal-federation-policy` command group.
 * Added `databricks aibi-dashboard-embedding-access-policy delete` command.
 * Added `databricks aibi-dashboard-embedding-approved-domains delete` command.

OpenAPI commit a6a317df8327c9b1e5cb59a03a42ffa2aabeef6d (2024-12-16)
Dependency updates:
 * Upgrade TF provider to 1.62.0 ([#2030](#2030)).
 * Upgrade Go SDK to 0.54.0 ([#2029](#2029)).
 * Bump TF codegen dependencies to latest ([#1961](#1961)).
 * Bump golang.org/x/term from 0.26.0 to 0.27.0 ([#1983](#1983)).
 * Bump golang.org/x/sync from 0.9.0 to 0.10.0 ([#1984](#1984)).
 * Bump github.com/databricks/databricks-sdk-go from 0.52.0 to 0.53.0 ([#1985](#1985)).
 * Bump golang.org/x/crypto from 0.24.0 to 0.31.0 ([#2006](#2006)).
 * Bump golang.org/x/crypto from 0.30.0 to 0.31.0 in /bundle/internal/tf/codegen ([#2005](#2005)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants