Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add support for cluster logs delivery to UC Volumes #4492

Merged
merged 3 commits into from
Feb 25, 2025
Merged

[Feature] Add support for cluster logs delivery to UC Volumes #4492

merged 3 commits into from
Feb 25, 2025

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 12, 2025

Changes

Add documentation for cluster logs delivery to UC Volumes, and adjust volumes.destination attribute to required.

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • using Go SDK
  • using TF Plugin Framework

@alexott alexott requested review from a team as code owners February 12, 2025 14:56
@alexott alexott requested review from hectorcast-db and removed request for a team February 12, 2025 14:56
mgyucht
mgyucht reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! From what I can see, it was already supported but not documented?

@alexott alexott requested a review from mgyucht February 21, 2025 14:28
@github-actions GitHub Actions
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 4492
  • Commit SHA: 432a334c8d2f312166ecc4d7a7f68faa236720c4

Checks will be approved automatically on success.

@alexott alexott requested a review from nkvuong February 24, 2025 10:37
nkvuong
nkvuong approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@nkvuong nkvuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexott alexott added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit e9cba0f Feb 25, 2025
13 checks passed
@alexott alexott deleted the feature/uc-volumes-cluster-logs branch February 25, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkvuong nkvuong nkvuong approved these changes

@hectorcast-db hectorcast-db Awaiting requested review from hectorcast-db hectorcast-db is a code owner automatically assigned from databricks/eng-plat-auto-exp-reviewers

@mgyucht mgyucht Awaiting requested review from mgyucht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexott @mgyucht @nkvuong