[Fix] Delete databricks_sql_endpoint that failed to start
#4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
alexott
approved these changes
Feb 24, 2025
sql/resource_sql_endpoint.go
Outdated
| // Rollback by deleting the warehouse | ||
| rollbackErr := w.Warehouses.DeleteById(ctx, wait.Id) | ||
| if rollbackErr != nil { | ||
| return fmt.Errorf("failed deleting warehouse: %w", rollbackErr) |
There was a problem hiding this comment.
This will hide an original error. Maybe we can put it here as well?
There was a problem hiding this comment.
agreed, updated the error message :)
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
nkvuong
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
databricks_sql_endpointresource ("CLASSIC" type) #4496Tests
make testrun locally