Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix writing to a Postgres table with a schema #195

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix writing to a Postgres table with a schema #195

merged 2 commits into from
Dec 10, 2024
+117 −53

Conversation

sgrebnov
Copy link
Collaborator

@sgrebnov sgrebnov commented Dec 10, 2024 •
edited
Loading

Fixes issues when

Error: "Tonic error: status: Internal, message: "Error writing data: Unable to execute the table insert for table_name: External error: The table 'table_schema.table_name' doesn't exist in the Postgres server\

Includes test_table_insertion_with_schema unit test

@sgrebnov sgrebnov force-pushed the sgrebnov/pg-write-schema-support branch from 3e49cfe to 74344ca Compare December 10, 2024 02:20
@sgrebnov sgrebnov changed the title Fix writing to a table with a schema (Postgres, SQLite) Fix writing to a Postgres table with a schema Dec 10, 2024
@sgrebnov sgrebnov merged commit afd31a7 into spiceai Dec 10, 2024
3 checks passed
@sgrebnov sgrebnov deleted the sgrebnov/pg-write-schema-support branch December 10, 2024 02:57
@sgrebnov sgrebnov mentioned this pull request Dec 10, 2024
Merged
@phillipleblanc phillipleblanc mentioned this pull request Dec 10, 2024
Merged
phillipleblanc added a commit that referenced this pull request Dec 10, 2024
@phillipleblanc
Revert "Fix writing to a Postgres table with a schema (#195)"
ed7c268 
This reverts commit afd31a7.
sgrebnov added a commit that referenced this pull request Dec 10, 2024
@sgrebnov
Revert "Revert "Fix writing to a Postgres table with a schema (#195)""
d9fd6d6 
This reverts commit ed7c268.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrebnov @phillipleblanc