Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Feature/grant_CREATE_to_collaborator #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stacyho
Copy link

@stacyho stacyho commented Dec 16, 2016

Worked on Issue #157

  • Added ability for owner of a repository to grant CREATE privilege to collaborators.
  • Postgres problem: If a collaborator creates a table in another user's repository, only the collaborator can see / select that specific table.

@stacyho stacyho changed the title grant create privilege to collaborator Feature/grant create privilege to collaborator Dec 16, 2016
@stacyho stacyho changed the title Feature/grant create privilege to collaborator Feature/grant_CREATE_to_collaborator Dec 16, 2016
@@ -221,6 +227,15 @@ def add_collaborator(self, repo, collaborator, db_privileges=[]):
collaborator, repo, privileges_str, collaborator]
params = tuple(map(lambda x: AsIs(x), params))
res = self.execute_sql(query, params)

query = ('BEGIN;'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that this grants CREATE to all users when added as collaborators. There's no check grantCreatePrivilege's value.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also has one too many spaces, though that's more of a silly codeclimate issue.
https://codeclimate.com/github/datahuborg/datahub/pull/204

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants