Skip to content

Commit

Permalink
ARROW-17172: [C++][Python] test_cython_api fails on windows (apache#1…
Browse files Browse the repository at this point in the history
…4133)

Tis PR adds `CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1` to the AppVeyor setup to make `test_cython.py` succeed as the extension module being built fails loading in a subprocess otherwise.

Lead-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Signed-off-by: Alenka Frim <[email protected]>
  • Loading branch information
AlenkaF authored Sep 15, 2022
1 parent e8aa1b9 commit d8f64ee
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions ci/appveyor-cpp-setup.bat
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ mamba update -q -y -c conda-forge --all || exit /B
@rem Create conda environment
@rem

@rem Workaround for ARROW-17172
@rem This seems necessary for test_cython.py to succeed, otherwise
@rem the extension module being built would fail loading in a subprocess.
set CONDA_DLL_SEARCH_MODIFICATION_ENABLE=1
set CONDA_PACKAGES=

if "%ARROW_BUILD_GANDIVA%" == "ON" (
Expand Down
2 changes: 0 additions & 2 deletions python/pyarrow/tests/test_cython.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,6 @@ def check_cython_example_module(mod):
mod.cast_scalar(scal, pa.list_(pa.int64()))


@pytest.mark.skipif(sys.platform == "win32",
reason="ARROW-17172: currently fails on windows")
@pytest.mark.cython
def test_cython_api(tmpdir):
"""
Expand Down

0 comments on commit d8f64ee

Please sign in to comment.