upgrade Heroku/Docker to 12.22, upgrade min node version to 10.17 to …

…be min version supported by sqlite3 module, and accomodate weird h: old heroku redis urls in new library

.nvmrc

@@ -1 +1 @@
-10
+12

Dockerfile

@@ -1,5 +1,5 @@
-ARG BUILDER_IMAGE=node:10.15
-ARG RUNTIME_IMAGE=node:10.15-alpine
+ARG BUILDER_IMAGE=node:12.22
+ARG RUNTIME_IMAGE=node:12.22-alpine
 ARG PHONE_NUMBER_COUNTRY=US
 
 FROM ${BUILDER_IMAGE} as builder

package.json

@@ -4,7 +4,7 @@
   "description": "Spoke",
   "main": "src/server",
   "engines": {
-    "node": ">=10.3",
+    "node": ">=10.17",
     "npm": "3.10.10"
   },
   "scripts": {
@@ -229,6 +229,7 @@
     "react-formal": "2.2.2",
     "react-router": "^3.2.0",
     "react-tooltip": "^4.2.13",
-    "recompose": "^0.30.0"
+    "recompose": "^0.30.0",
+    "webpack-cli": "^4.7.2"
   }
 }

src/server/models/thinky.js

@@ -47,7 +47,11 @@ thinkyConn.r.getCountDistinct = async (query, distinctConstraint) =>
 const redisUrl = process.env.REDIS_TLS_URL || process.env.REDIS_URL;
 
 if (redisUrl) {
-  const redisSettings = { url: redisUrl };
+  // new redis client doesn't respect username placeholders so replace it
+  // this is especially true for legacy Heroku instances which had redis://h:<password>...
+  const redisSettings = {
+    url: redisUrl.replace(/redis:\/\/\w+:/, "redis://:")
+  };
   if (/rediss/.test(redisSettings.url)) {
     // secure redis protocol for Redis 6.0+
     // https://devcenter.heroku.com/articles/securing-heroku-redis#using-node-js