Merge branch 'master' of github.com:andrewplummer/Sugar

dbravender · Oct 4, 2012 · 15f5b09 · 15f5b09
2 parents 7d4d5b2 + b187958
commit 15f5b09
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+v1.3.6
+======
+
+### API Changes ###
+
+- Faster String#repeat (Issue #214 - Thanks to @termi!).
+
 v1.3.5
 ======
 

diff --git a/lib/string.js b/lib/string.js
@@ -761,17 +761,21 @@
      *
      *   'jumpy'.repeat(2) -> 'jumpyjumpy'
      *   'a'.repeat(5)     -> 'aaaaa'
+     *   'a'.repeat(0)     -> ''
      *
      ***/
     'repeat': function(num) {
-      var str = '', i = 0;
-      if(isNumber(num) && num > 0) {
-        while(i < num) {
-          str += this;
-          i++;
+      var result = '', str = this;
+      if(!isNumber(num) || num < 1) return '';
+      while (num) {
+        if (num & 1) {
+          result += str;
+        }
+        if (num >>= 1) {
+          str += str;
         }
       }
-      return str;
+      return result;
     },
 
     /***
@@ -859,7 +863,6 @@
       });
       return context;
     }
-
   });