Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply column quoting to unit tests - continued #204

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mpatek
Copy link

@mpatek mpatek commented May 11, 2024

resolves #205
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mpatek mpatek requested a review from a team as a code owner May 11, 2024 12:48
Copy link

cla-bot bot commented May 11, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @mpatek

Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@robertf-b
Copy link

@mpatek @colin-rogers-dbt @dbeatty10 Curious what is required to get this moving again?

@colin-rogers-dbt
Copy link
Contributor

thanks for flagging @robertf-b, I don't see any blockers here other than adding a test case to cover this.

We'll just need to update our test fixture to include some reserved keywords to validate this works (and that we don't break it in the future). Will queue it up for consideration.

@megetron3
Copy link

@mpatek - any progress on this PR?

@cboethigtrellance
Copy link

Is there anything required to get this moving? Would like to help at all to get this through

@mikealfare mikealfare added enhancement New feature or request and removed enhancement New feature or request labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes community This PR is from a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unit tests fail when input has a column name with a quoted identifier
7 participants