Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Parameterize acceptance tests for local runs #322

Merged
merged 17 commits into from
Mar 12, 2025
Merged

chore: Parameterize acceptance tests for local runs #322

merged 17 commits into from
Mar 12, 2025

Conversation

csquire
Copy link
Contributor

@csquire csquire commented Dec 10, 2024

Adds the ability to specify details required for executing the acceptance tests against an arbitrary test account. This allows users to more easily run the acceptance tests locally.

Add to the existing set of environment variable to provide the necessary configuration to execute the tests against your own account:

DBT_CLOUD_ACCOUNT_ID=1234
DBT_CLOUD_USER_ID=4321
DBT_CLOUD_USER_EMAIL=<email_address>
DBT_CLOUD_TOKEN=<api_token>
DBT_CLOUD_HOST_URL=https://<host>/api
DBT_CLOUD_GROUP_IDS=1,2,3
[email protected]:<github-org>/<dbt-project>.git
ACC_TEST_GITHUB_APP_INSTALLATION_ID=1234

@csquire csquire changed the title Parameterize acceptance tests for local runs chore: Parameterize acceptance tests for local runs Dec 10, 2024
@csquire csquire requested a review from chasewalden December 10, 2024 16:55
@csquire csquire force-pushed the parameterize-acc-tests branch 2 times, most recently from 6f3cd4a to cf6e7bf Compare December 13, 2024 16:05
@csquire csquire force-pushed the parameterize-acc-tests branch from cf6e7bf to 77e1c52 Compare March 12, 2025 14:01
@csquire csquire requested a review from a team as a code owner March 12, 2025 14:01
@csquire csquire requested a review from a team March 12, 2025 14:02
@VanTudor VanTudor self-requested a review March 12, 2025 14:42
@VanTudor VanTudor self-assigned this Mar 12, 2025
VanTudor
VanTudor reviewed Mar 12, 2025
View reviewed changes
Copy link

@VanTudor VanTudor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm overall after going through the code. Working on getting this to run on my local machine atm. In the meantime, I left a comment

@VanTudor VanTudor self-requested a review March 12, 2025 16:31
VanTudor
VanTudor approved these changes Mar 12, 2025
View reviewed changes
Copy link

@VanTudor VanTudor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran tests locally and went through code again. Only thing that fails is the IP restrictions tests, which does so because my account is not yet Business critical. Lgtm! 🚀

@csquire csquire force-pushed the parameterize-acc-tests branch from c3646da to 37ea0fd Compare March 12, 2025 16:42
@csquire csquire merged commit 865cc43 into dbt-labs:main Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanTudor VanTudor VanTudor approved these changes

@chasewalden chasewalden Awaiting requested review from chasewalden

Assignees

@VanTudor VanTudor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csquire @VanTudor