Skip to content

Commit

Permalink
Set default pullPolicy of IfNotPresent for helm chart
Browse files Browse the repository at this point in the history
This will allow preloading images into the cluster
so the images dont have to be pulled. This is useful
for images/tags that are currently not in a public
registry. Otherwise it will try pulling anyways
and fail even if the image is already known to the
local daemon.
  • Loading branch information
cedricziel committed Jun 22, 2020
1 parent 4063325 commit f06a04f
Show file tree
Hide file tree
Showing 13 changed files with 14 additions and 1 deletion.
3 changes: 2 additions & 1 deletion K8s/helm/templates/cart-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ spec:
containers:
- name: cart
image: {{ .Values.image.repo }}/rs-cart:{{ .Values.image.version }}
# agent networking access
imagePullPolicy: {{ .Values.image.pullPolicy }}
# agent networking access
env:
- name: INSTANA_AGENT_HOST
valueFrom:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/catalogue-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: catalogue
image: {{ .Values.image.repo }}/rs-catalogue:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
env:
- name: INSTANA_AGENT_HOST
valueFrom:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/dispatch-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: dispatch
image: {{ .Values.image.repo }}/rs-dispatch:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
env:
# agent networking access
- name: INSTANA_AGENT_HOST
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/mongodb-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: mongodb
image: {{ .Values.image.repo }}/rs-mongodb:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- containerPort: 27017
resources:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/mysql-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: mysql
image: {{ .Values.image.repo }}/rs-mysql-db:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
# added for Istio
securityContext:
capabilities:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/payment-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ spec:
containers:
- name: payment
image: {{ .Values.image.repo }}/rs-payment:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
# agent networking access
env:
- name: INSTANA_AGENT_HOST
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/rabbitmq-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: rabbitmq
image: rabbitmq:3.7-management-alpine
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- containerPort: 5672
- containerPort: 15672
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/ratings-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: ratings
image: {{ .Values.image.repo }}/rs-ratings:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- containerPort: 80
resources:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/redis-statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
containers:
- name: redis
image: redis:4.0.6
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- containerPort: 6379
volumeMounts:
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/shipping-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: shipping
image: {{ .Values.image.repo }}/rs-shipping:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
ports:
- containerPort: 8080
# it's Java it needs lots of memory
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/user-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: user
image: {{ .Values.image.repo }}/rs-user:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
env:
# agent networking access
- name: INSTANA_AGENT_HOST
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/templates/web-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ spec:
containers:
- name: web
image: {{ .Values.image.repo }}/rs-web:{{ .Values.image.version }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if .Values.eum.key }}
env:
- name: INSTANA_EUM_KEY
Expand Down
1 change: 1 addition & 0 deletions K8s/helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
image:
repo: robotshop
version: latest
pullPolicy: IfNotPresent

# Alternative payment gateway URL
# Default is https://www.paypal.com
Expand Down

0 comments on commit f06a04f

Please sign in to comment.