Skip to content

Commit

Permalink
display HMR module logger message as a collapsed group
Browse files Browse the repository at this point in the history
  • Loading branch information
rrharvey committed Jul 11, 2017
1 parent 066b0ac commit 8789f59
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
10 changes: 7 additions & 3 deletions hot/log-apply-result.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,14 @@ module.exports = function(updatedModules, renewedModules) {
} else {
log("info", "[HMR] Updated modules:");
renewedModules.forEach(function(moduleId) {
if(moduleId.lastIndexOf) {
moduleId = moduleId.substring(moduleId.lastIndexOf("!") + 1);
if(typeof moduleId === "string") {
var parts = moduleId.split("!");
log.groupCollapsed("[HMR] - " + parts.pop());
log("info", "[HMR] - " + moduleId);
log.groupEnd();
} else {
log("info", "[HMR] - " + moduleId);
}
log("info", "[HMR] - " + moduleId);
});
var numberIds = renewedModules.every(function(moduleId) {
return typeof moduleId === "number";
Expand Down
8 changes: 8 additions & 0 deletions hot/log.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
var logLevel = "info";

function dummy() { }

module.exports = function(level, msg) {
if(logLevel === "info" && level === "info")
return console.log(msg);
Expand All @@ -9,6 +11,12 @@ module.exports = function(level, msg) {
return console.error(msg);
};

module.exports.group = console.group || dummy;

module.exports.groupCollapsed = console.groupCollapsed || dummy;

module.exports.groupEnd = console.groupEnd || dummy;

module.exports.setLogLevel = function(level) {
logLevel = level;
};

0 comments on commit 8789f59

Please sign in to comment.