Allow expanding sidebar by clicking on non-links (OpenZeppelin#370)

dcorral · Sep 1, 2023 · f943c10 · f943c10
1 parent 9ae87f1
commit f943c10
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/ui/src/css/specific/navigation.scss b/ui/src/css/specific/navigation.scss
@@ -78,10 +78,9 @@
   font-size: 1rem;
 }
 
-.nav-li {
-  a:hover {
-    opacity: .8;
-  }
+.nav-link:hover {
+  opacity: .8;
+  cursor: pointer;
 }
 
 .nav-link code {

diff --git a/ui/src/js/05-sidr-menu.js b/ui/src/js/05-sidr-menu.js
@@ -21,9 +21,10 @@
     if (isDefaultCollapsed && !o.parentElement.classList.contains('nav-li-active-parent')) {
       o.classList.toggle('toggled');
     }
-    o.addEventListener('click', function (e) {
-      this.classList.toggle('toggled');
-    });
+    const toggle = () => o.classList.toggle('toggled');
+    o.addEventListener('click', toggle);
+    const span = [...o.parentElement.children].find(c => c.matches('span.nav-link'));
+    span?.addEventListener('click', toggle);
   });
 
   // The preinit class sets up collapsed states before JS executes to avoid flashing uncollapsed menu

diff --git a/ui/theme/partials/navigation-tree.hbs b/ui/theme/partials/navigation-tree.hbs
@@ -7,7 +7,7 @@
     {{{content}}}
   </a>
   {{else}}
-  {{#if content}}<span>{{{content}}}</span>{{/if}}
+  {{#if content}}<span {{#if items}}class="nav-link"{{/if}}>{{{content}}}</span>{{/if}}
   {{/if}}
   {{!-- Nesting --}}
   {{#if items}}