Add python3 compatibility with working tests. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcwatson
added a commit
that referenced
this pull request
Sep 15, 2014
Add python3 compatibility with working tests.
|
Thanks! I'll probably go back and remove Django as a dependency (I want to keep the armor/pad functions usable without Django), but aside from that looks good! |
|
No problem! Nice to see it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I looked into adding Python 3 support. Tests still work, but I had to enforce arguments going into the padding functions to be binary/bytes.
This is a theoretical port ("made the tests work"), but if people could look whether or not it works for them in their projects, that would be great :-)