Exit with nice error message failing to get repositories

If we throw an OfflineImapError in case of the Repository() initialization, we display the nice error message and exit rather than bomb out with a traceback. Misconfiguring a repository name in the configuration file is now nicely pointed out to the user. Signed-off-by: Sebastian Spaeth <[email protected]>
dddmaster · Aug 31, 2012 · 04ffae2 · 04ffae2
1 parent 103524c
commit 04ffae2
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/offlineimap/accounts.py b/offlineimap/accounts.py
@@ -217,13 +217,19 @@ def unlock(self):
 
     def syncrunner(self):
         self.ui.registerthread(self)
-        accountmetadata = self.getaccountmeta()
-        if not os.path.exists(accountmetadata):
-            os.mkdir(accountmetadata, 0o700)
-
-        self.remoterepos = Repository(self, 'remote')
-        self.localrepos  = Repository(self, 'local')
-        self.statusrepos = Repository(self, 'status')
+        try:
+            accountmetadata = self.getaccountmeta()
+            if not os.path.exists(accountmetadata):
+                os.mkdir(accountmetadata, 0o700)
+
+            self.remoterepos = Repository(self, 'remote')
+            self.localrepos  = Repository(self, 'local')
+            self.statusrepos = Repository(self, 'status')
+        except OfflineImapError as e:
+            self.ui.error(e, exc_info()[2])
+            if e.severity >= OfflineImapError.ERROR.CRITICAL:
+                raise
+            return
 
         # Loop account sync if needed (bail out after 3 failures)
         looping = 3